Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-290 Add ExtractText to FlowConfiguration.h so that it can b… #177

Closed
wants to merge 1 commit into from

Conversation

achristianson
Copy link
Contributor

…e recognized in flow configurations

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@phrocker
Copy link
Contributor

phrocker commented Nov 5, 2017

I don't know why those headers made their way back into FlowConfiguration ( could have been a mistaken merge on my part ), but the current approach is to use LoadProcessors. Soon we'll move to linking them forcefully -- the next step in breaking out core-minifi from minifi:

Here is a branch that contains that single change isolated that would apply here. Feel free to cherry pick that commit
https://github.com/apache/nifi-minifi-cpp/compare/master...phrocker:PROCFIX?expand=1

Edit: I copied and pasted the changes into a branch. I clearly didn't get all of them as I see a travis failure . I'll try to correct that at some point.

@achristianson
Copy link
Contributor Author

@phrocker glad to see a better fix already exists. I suggest we prioritize getting that specific fix into master because right now this is a blocker for anyone trying to use that processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants