Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-307: Support text mode in GenerateFlowFile #195

Closed
wants to merge 1 commit into from

Conversation

dtrodrigues
Copy link
Contributor

@dtrodrigues dtrodrigues commented Nov 18, 2017

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

Copy link
Contributor

@achristianson achristianson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks good to me.

@achristianson
Copy link
Contributor

You have a small linter issue:

Done processing /home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GetFile.cpp
/home/travis/build/apache/nifi-minifi-cpp/libminifi/src/processors/GenerateFlowFile.cpp:48:  For a static/global string constant, use a C style string instead: "static const char TEXT_CHARS[]".  [runtime/string] [4]

@dtrodrigues
Copy link
Contributor Author

Linter issues should be fixed now

MINIFICPP-307 - fix linter issues, typo
@asfgit asfgit closed this in 5a80197 Nov 27, 2017
@dtrodrigues dtrodrigues deleted the MINIFICPP-307 branch August 3, 2018 00:26
nghiaxlee pushed a commit to nghiaxlee/nifi-minifi-cpp that referenced this pull request Jul 8, 2019
MINIFICPP-307 - fix linter issues, typo

This closes apache#195.

Signed-off-by: Marc Parisi <phrocker@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants