Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an initial GitHub PR template. #20

Closed
wants to merge 1 commit into from

Conversation

apiri
Copy link
Member

@apiri apiri commented Oct 19, 2016

Providing an initial PR template to provide guidance for those submitting contributions.

Copy link
Contributor

@jdye64 jdye64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apiri Your PR violates the "does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character." in your template =)

@alopresto
Copy link

+1 to @jdye64 's comment.

@apiri
Copy link
Member Author

apiri commented Feb 27, 2017

Totally missed the snark on this thread. I can't meet the requirements of a non-existent PR if they aren't there yet. ;)

@asfgit asfgit closed this in 6f447c8 Mar 2, 2017
@apiri apiri deleted the add-pr-template branch April 5, 2017 16:13
nghiaxlee referenced this pull request in nghiaxlee/nifi-minifi-cpp Jul 8, 2019
This closes #20

Signed-off-by: Jeremy Dyer <jeremydyer@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants