MINIFI-124 The active_pid() function kill -s 0 <PID> returns 0 on success (PID i… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingogre
changed the title
codingogre
changed the title
… on success (PID is currently running), yet the if statement in stop case statement is checking for 0 as a failure condition.
codingogre
force-pushed
the
minifi.sh-fix
branch
from
c51dc1f
to
fb18ff1
Compare
|
reviewing |
|
Looks good here and thanks for catching! Will merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MINIFI-124. In the active_pid() function kill -s 0 returns 0 on success (the PID is currently running), yet the if statement in the stop case statement is checking for 0 as a failure condition.