New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-602: Add ability to use CSV within url field #395
Conversation
79a3dda
to
1b2b91e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes, build, and tests all look good. verified handling using multiple values for site to site. a few comments were left behind that I can clean up on merge, otherwise looks good to go.
@@ -88,12 +93,11 @@ class RemoteProcessorGroupPort : public core::Processor { | |||
if (uuid != nullptr) { | |||
uuid_copy(protocol_uuid_, uuid); | |||
} | |||
site2site_port_ = -1; | |||
//siteTosite_port_ = -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should get removed
} else if (protocol_.find("http") != std::string::npos) { | ||
port_ = 80; | ||
auto urls = utils::StringUtils::split(val, ","); | ||
//url_ = val; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should get removed
std::string url_; | ||
std::vector<struct RPG> nifi_instances_; | ||
|
||
//std::vector<std::string> urls_; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should get removed
This closes apache#395. Signed-off-by: Aldrin Piri <aldrin@apache.org>
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.