MINIFICPP-618: Add C2 triggers, first of which monitors a local file … #405
Conversation
|
Committing test soon -- added PR to have someone evaluate this early |
| } | ||
|
|
||
|
|
||
| /** |
There was a problem hiding this comment.
I think this comment is for a different function
There was a problem hiding this comment.
You were right. I went through and added some comments and probably would have missed this had you not mentioned it. Thanks! adding some docs now to our readmes.
Made an early PR to give some people a chance to review and test -- so really appreciate all input!
phrocker
force-pushed
the
MINIFICPP-618
branch
from
2f44205
to
5e5e9e0
Compare
phrocker
force-pushed
the
MINIFICPP-618
branch
from
5e5e9e0
to
3a4062f
Compare
phrocker
force-pushed
the
MINIFICPP-618
branch
from
b653680
to
f322529
Compare
clear. MINIFICPP-624: Add alternate names for C2 configuration items and support both
| @@ -60,6 +60,9 @@ class Properties { | |||
| // Get the config value | |||
| bool get(std::string key, std::string &value); | |||
|
|
|||
| // Get the config value | |||
There was a problem hiding this comment.
This should document the alternate keys and why it is different than the above
There was a problem hiding this comment.
I think you're getting intermediate commits as I work through issues with another Apache person -- this one isn't quite ready for review. I'll close the PR in the meantime.
There was a problem hiding this comment.
No apology, please. It's my fault for opening early!. I truly appreciate the input and hope that when I re-open it you have an opportunity to take a look!
…for changes
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.