MINIFICPP-741: Allow proper error catching with PyErr_Fetch #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpadboda
reviewed
Mar 7, 2019
| @@ -967,6 +1009,14 @@ class none : public object { | |||
| none() : object(Py_None, borrowed_t{}) { } | |||
| }; | |||
|
|
|||
| #if PY_MAJOR_VERSION >= 3 | |||
There was a problem hiding this comment.
Do we plan to support Python 2 at all?
There was a problem hiding this comment.
I don't know if anything in our docs say we won't.
There was a problem hiding this comment.
I would think it over if we have the possibility to decide.
Python 2 is already pretty old, not sure supporting that worth the effort.
There was a problem hiding this comment.
Are you asking because of the third party conditional?
|
reviewing |
apiri
approved these changes
Mar 9, 2019
nghiaxlee
pushed a commit
to nghiaxlee/nifi-minifi-cpp
that referenced
this pull request
Jul 8, 2019
This closes apache#500. Signed-off-by: Aldrin Piri <aldrin@apache.org>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.