-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MINIFICPP-1024 - Fix CentOS and Fedora docker builds #641
Conversation
docker/centos/Dockerfile
Outdated
@@ -35,7 +35,8 @@ ENV MINIFI_BASE_DIR /opt/minifi | |||
RUN mkdir -p $MINIFI_BASE_DIR | |||
USER $USER | |||
|
|||
RUN yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel gcc g++ sudo git which maven | |||
RUN yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel gcc g++ sudo git which maven make | |||
RUN yum -y install openssl openssl-devel openssl-static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is intended to be temporary until the third party compilations are fixed in MINIFICPP-1022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait on 1022, then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, removed the hotfix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 why not wait on 1022? Will that take inordinately long?
docker/centos/Dockerfile
Outdated
@@ -35,7 +35,8 @@ ENV MINIFI_BASE_DIR /opt/minifi | |||
RUN mkdir -p $MINIFI_BASE_DIR | |||
USER $USER | |||
|
|||
RUN yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel gcc g++ sudo git which maven | |||
RUN yum -y install java-1.8.0-openjdk java-1.8.0-openjdk-devel gcc g++ sudo git which maven make | |||
RUN yum -y install openssl openssl-devel openssl-static |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait on 1022, then
@@ -34,6 +37,7 @@ echo "CMake Source Directory: $CMAKE_SOURCE_DIR" | |||
echo "MiNiFi Package: $MINIFI_SOURCE_CODE" | |||
|
|||
# Copy the MiNiFi source tree to the Docker working directory before building | |||
rm -rf $CMAKE_SOURCE_DIR/docker/${DISTRO_NAME}/minificppsource/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch!
@@ -18,6 +18,9 @@ | |||
|
|||
#!/bin/bash | |||
|
|||
# Fail on errors | |||
set -e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. look forward to what 1022 brings!
I'll merge once travis finishes, but I suspect it'll be red on centos. I think that's acceptable, so I'll merge after just to make sure nothing else breaks. |
Yep, it will also be red on Fedora, hopefully for not too long. Thanks! |
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.