MINIFICPP-1028 - http url parsing without port fails

[arpadboda]

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file?
• If applicable, have you updated the NOTICE file?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[phrocker]

Thanks! We have this in a few places throughout the project, but those may be for testing. We've had this issue for other cases that tripped us up -- makes me wonder if we could just use civetweb for something like this.

[bakaid]

Thanks! We have this in a few places throughout the project, but those may be for testing. We've had this issue for other cases that tripped us up -- makes me wonder if we could just use civetweb for something like this.

cURL has a dedicated URL API, that can parse URLs: https://github.com/curl/curl/blob/master/include/curl/urlapi.h
However, that would require everything that would want to use this to depend on cURL, and while I am all for not using homecooked parsers, I am not sure whether that's something we want.

[phrocker]

Thanks! We have this in a few places throughout the project, but those may be for testing. We've had this issue for other cases that tripped us up -- makes me wonder if we could just use civetweb for something like this.

cURL has a dedicated URL API, that can parse URLs: https://github.com/curl/curl/blob/master/include/curl/urlapi.h
However, that would require everything that would want to use this to depend on cURL, and while I am all for not using homecooked parsers, I am not sure whether that's something we want.

Yeah a few of us previously discussed breaking that out -- then someone suggested using civet's parsers. Civet, at the time, was not an extension; however, now that we have a 'classloader' like capability we could specialize the parser based on extensions and have URLParser use a variant that relies on curl if it is built. cURL support will be quite prevalent, so we would rely on their more tested parser. That would mean we must still maintain ours, but have clear documentation that using our parser may have risk versus the one in curl-land.