MINIFICPP-1034 - MQTT processors doesnt work #650
Conversation
| relationships.insert(Success); | ||
| relationships.insert(Failure); | ||
| setSupportedRelationships(relationships); | ||
| MQTTClient_SSLOptions sslopts_ = MQTTClient_SSLOptions_initializer; |
There was a problem hiding this comment.
This was just hiding instead of initializing the member. So it had no chance to work, but it didn't pop up given the security properties are not exported, so it's never referenced.
| relationships.insert(Failure); | ||
| setSupportedRelationships(relationships); | ||
| MQTTClient_SSLOptions sslopts_ = MQTTClient_SSLOptions_initializer; | ||
| sslEnabled_ = false; |
There was a problem hiding this comment.
Too bad it was only initialized here, but none of the baseclasses called this function.
| @@ -46,32 +46,15 @@ core::Property AbstractMQTTProcessor::SecurityCA("Security CA", "File or directo | |||
| core::Property AbstractMQTTProcessor::SecurityCert("Security Cert", "Path to client's public key (PEM) used for authentication", ""); | |||
| core::Property AbstractMQTTProcessor::SecurityPrivateKey("Security Private Key", "Path to client's private key (PEM) used for authentication", ""); | |||
| core::Property AbstractMQTTProcessor::SecurityPrivateKeyPassWord("Security Pass Phrase", "Private key passphrase", ""); | |||
There was a problem hiding this comment.
These are not exported, but clearly never been tested as well, so created https://issues.apache.org/jira/browse/MINIFICPP-1035 to address this.
| std::shared_ptr<core::FlowFile> flowFile = session->get(); | ||
|
|
||
| if (!flowFile) { | ||
| if (!reconnect()) { |
There was a problem hiding this comment.
This way we reconnect even if there is no FlowFile to publish. I am not saying that it is necessarily a problem, but it changes the previous behaviour. Is this intentional?
There was a problem hiding this comment.
Reconnect doesn't do anything unless the connection is interrupted.
If we have an existing connection (expected case), it just returns true.
There was a problem hiding this comment.
Yeah, that's the conclusion I reached as well, should be fine, thanks.
arpadboda
force-pushed
the
MINIFICPP-1034
branch
from
f9b36cf
to
8e1b7ca
Compare
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.