MINIFICPP-1022 - Refactored third party build system #661
Conversation
|
Please read https://github.com/bakaid/nifi-minifi-cpp/blob/MINIFICPP-1022/ThirdParties.md before reviewing other parts of this PR. I still have to run tests to make sure I didn't break anything, including JNI and python. |
bakaid
force-pushed
the
MINIFICPP-1022
branch
from
964e560
to
2c08b63
Compare
|
I like the idea of this PR for potentially 0.8 or 1.x, but I haven't resolved that in my head. I think the bigger thing is that perhaps we could move the third parties readme to a contribution folder and integrate it as a link in the contrib guide. Is there a way we could automate checks to for this? |
README.md
Outdated
| @@ -530,6 +530,10 @@ On Windows it is suggested that MSI be used for installation. | |||
|
|
|||
| Please see [Extensions.md](Extensions.md) on how to build and run conditionally built dependencies and extensions. | |||
|
|
|||
| ### Third parties | |||
|
|
|||
| Please see [ThirdParties.md](ThirdParties.md) on how MiNiFi builds and uses third party libraries and how you can add new ones. | |||
There was a problem hiding this comment.
This seems more developer focused, perhaps this could be split into the contrib guide?
There was a problem hiding this comment.
Yep, that's fair, moved the reference to CONTRIB.md
| ``` | ||
| add_library(foo INTERFACE) | ||
| target_include_directories(foo INTERFACE "${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/libfoo-1.0.0") | ||
| ``` |
There was a problem hiding this comment.
Nicely written, cool doc, I like it!
bakaid
force-pushed
the
MINIFICPP-1022
branch
from
2c08b63
to
a6d10aa
Compare
| # specific language governing permissions and limitations | ||
| # under the License. | ||
|
|
||
| function(target_wholearchive_library TARGET ITEM) |
There was a problem hiding this comment.
May god bless you for removing all the copy-paste occurrences of this! 🙏
bakaid
force-pushed
the
MINIFICPP-1022
branch
from
aefdc79
to
1d7c508
Compare
|
@arpadboda Addressed your review comments, I will start a final round of verification and self-review. |
|
@arpadboda macOS failure on Travis is an unrelated timeout at the very end, I've finished my verification, I'll merge soon. |
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.