MINIFICPP-1043 - FetchOPC should support reporting changes only #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bakaid
reviewed
Nov 5, 2019
|
|
||
| return std::string(charBuf.data(), charBuf.size()); | ||
| return std::string(charBuf.data(), sz); |
| nodedata.attributes["Full path"] = basePath + "/" + browsename; | ||
| nodedata.dataTypeID = UA_TYPES_COUNT; | ||
| UA_Variant* var = UA_Variant_new(); | ||
| if(UA_Client_readValueAttribute(client_, ref->nodeId.nodeId, var) == UA_STATUSCODE_GOOD && var->type != NULL && var->data != NULL) { | ||
| // Because the timestamps are eliminated in readValueAttribute for simplification |
There was a problem hiding this comment.
If possible, we should only do this if we are in lazy mode, otherwise this is unnecessary.
There was a problem hiding this comment.
Non-lazy does the same thing in the background, the 3rd party provides a simplified API function to hide this. (But swallows timestamps, that's why we can't use that here)
I don't mind having a bit more complex but single code path in case it has no performance drawbacks.
There was a problem hiding this comment.
Yes, this code part is a trimmed down version of UA_readValueAttribute with a slight modification. Despite checking lazy mode before running might be better, I then have to pass the lazy flag from fetchopc processor to this function, which I am not quite into.
msharee9
pushed a commit
to msharee9/nifi-minifi-cpp
that referenced
this pull request
Nov 23, 2019
Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#672
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.