Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1117 - minifi::Exception is now nothrow copyable #707

Closed
wants to merge 3 commits into from

Conversation

szaszm
Copy link
Member

@szaszm szaszm commented Jan 9, 2020

Implemented in terms of std::runtime_error

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@szaszm
Copy link
Member Author

szaszm commented Jan 9, 2020

I've added some boilerplate for string joining. I can remove it at some performance cost (extra std::string allocations) or additional dependency (boost::algorithm::join)

libminifi/include/Exception.h Outdated Show resolved Hide resolved
@szaszm
Copy link
Member Author

szaszm commented Jan 10, 2020

update:

  • fix ProcessorTests
  • move string utilities to StringUtils and generalize them
  • add unit test to cover the new StringUtils::join_pack

Moving the utilities from a private namespace to StringUtils means that they need to be more general IMO. I've extended them to work with any character type and do SFINAE checking on the string types.

This means quite some template code, which may not be welcome in this codebase. Suggestions are welcome.

@szaszm szaszm changed the title MINIFICPP-1117 - minifi::Exception is now nothrow copyable WIP: MINIFICPP-1117 - minifi::Exception is now nothrow copyable Jan 10, 2020
@szaszm szaszm changed the title WIP: MINIFICPP-1117 - minifi::Exception is now nothrow copyable MINIFICPP-1117 - minifi::Exception is now nothrow copyable Jan 13, 2020
Copy link
Contributor

@arpadboda arpadboda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arpadboda arpadboda closed this in 14dcab2 Jan 14, 2020
@szaszm szaszm deleted the MINIFICPP-1117 branch January 14, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants