MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations #789

…r corresponding .cpp files

…s-specific symbol imports

…ions

…dations make linter |& egrep -v '^Done processing|^Ignoring' | grep "Missing space before {" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/{/ {/" $1' sh

…ndations Script used: make linter |& egrep -v '^Done processing|^Ignoring' | grep "{ should almost always" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/[[:blank:]]*{/{/" $1 && perl -pi -e "s/\\n/ / if $. == $2 - 1" $1' sh This was run repeatedly until no more errors were present.

…lowing each other This can only be solved by removing the first visibility modifier, because otherwise either a ... followed by a blank line or a ... should be preceded by a blank line error occurs Script used (after all the aforementioned errors were cleared): make linter |& egrep -v '^Done processing|^Ignoring' | grep "Do not leave a blank line after" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2d" $1 && sed -i "" "$(expr $2 - 1)d" $1' sh

…linter recommendation Script used: make linter |& egrep -v '^Done processing|^Ignoring' | grep "An else should appear on the same line as the preceding }" | tr ":" " " | cut -d" " -f1,2 | sort -rn -k1 -k2 | xargs -n 2 sh -c 'sed -i "" "$2s/[[:blank:]]*else/else/" $1 && perl -pi -e "s/\\n/ / if $. == $2 - 1" $1' sh

…ions Script used: make linter |& egrep -v '^Done processing|^Ignoring' | grep "build/include_what_you_use" | tr ":" " " | cut -d" " -f1,7 | sort -rn -k1 -k2 | uniq | xargs -n 2 sh -c 'perl -pi -e "s/#pragma once/#pragma once\n\n#include $2/" $1' sh make linter |& egrep -v '^Done processing|^Ignoring' | grep "build/include_what_you_use" | tr ":" " " | cut -d" " -f1,7 | sort -rn -k1 -k2 | uniq | xargs -n 2 sh -c 'perl -pi -e "BEGIN { undef $/; } s/#ifndef (.*)\n#define \1/#ifndef \1\n#define \1\n\n#include $2/" $1' sh

Script used (ran until it performed no new changes): git diff --name-only master...$(git branch --show-current) | xargs perl -0777 -ne 'print "$ARGV $1\n" while /^(#include \<.*(?<!\.h)\>)\n\n(#include \<.*(?<!\.h)\>)$/mg' | xargs -n 3 sh -c 'perl -pi -e "s/$2 $3\n/$2 $3/g" $1' sh

…stent Also, fix incorrect header guard closing #endifs that were not reported due linter becoming confused on /* style comments Script used: git diff --name-only master...$(git branch --show-current) | xargs perl -0777 -pi -e 's/^(\s*}) \/\* namespace (.*) \*\/ *$/$1 \/\/ namespace $2/mg' make linter |& egrep -v '^Done processing|^Ignoring' |& grep -v "Done proces" | grep "endif line should be" | tr ":" " " | cut -d" " -f1,2,9-12 | xargs -n 3 sh -c 'sed -i "" "$2s;.*;$3;" $1' sh | less

…r comments, add NOLINT to non-explicit ctors mentioned by the linter

…e API breaking explicit

…ders

…ing, fix incorrect ctr explicitness

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations #789

MINIFICPP-1203 - Enable header linting in include directories and resolve linter recommendations #789

Commits on Jun 12, 2020