Update WindowsEventLog.cpp - NO JIRA - Hour math bug

[neuralfraud]

Line 81 is incorrect, results in an hour containing "00:00:00 PM"

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• Has your PR been rebased against the latest commit within the target branch (typically master)?

• Is your initial contribution a single, squashed commit?

For code changes:

• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file?
• If applicable, have you updated the NOTICE file?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[fgerlits]

Good catch, thanks for the fix!

[neuralfraud]

@fgerlits Thanks but also missed something. The SYSTEMTIME struct contains the hour as 0..23 - Thus "00" can still appear in the timestamp as 00:00:00 AM. See second commit. This should fully resolve the issue. Thank you.

[arpadboda]

Thanks @neuralfraud , nice spot!

I've created a Jira to handle the administrative part of this task for now ( https://issues.apache.org/jira/browse/MINIFICPP-1302 ), although let me suggest to subscribe to dev@nifi.apache.org and request a contributor access to the project. Your further contributions are welcome!

[szaszm]

You can subscribe to the list by sending an email to dev-subscribe@nifi.apache.org.

https://nifi.apache.org/mailing_lists.html