MINIFICPP-1376 Create PutS3Object processor #915
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lordgamez
force-pushed
the
MINIFICPP-1376
branch
from
e72f185
to
f1ac6c8
Compare
adamdebreceni
approved these changes
Oct 9, 2020
lordgamez
force-pushed
the
MINIFICPP-1376
branch
2 times, most recently
from
1dc3e95
to
5ecdec8
Compare
szaszm
reviewed
Oct 21, 2020
lordgamez
force-pushed
the
MINIFICPP-1376
branch
from
d1f6d68
to
e83b4f4
Compare
arpadboda
reviewed
Oct 27, 2020
| EXCLUDE_FROM_ALL TRUE | ||
| ) | ||
| ExternalProject_Add( | ||
| aws-sdk-cpp-external | ||
| GIT_REPOSITORY "https://github.com/aws/aws-sdk-cpp.git" | ||
| GIT_TAG "1.7.109" | ||
| GIT_TAG "1.8.52" |
| buffer.reserve(BUFFER_SIZE); | ||
| read_size_ = 0; | ||
| while (read_size_ < flow_size_) { | ||
| auto next_read_size = flow_size_ - read_size_ < BUFFER_SIZE ? flow_size_ - read_size_ : BUFFER_SIZE; |
There was a problem hiding this comment.
The right side looks like an std::min to me :)
| } | ||
|
|
||
| void AWSSdkLogger::LogStream(Aws::Utils::Logging::LogLevel log_level, const char* tag, const Aws::OStringStream &message_stream) { | ||
| switch (log_level) { |
There was a problem hiding this comment.
Instead of copy-pasting the logic, can't this simply call the one above?
| logger_->log_debug("PutS3Object: Storage Class [%s]", put_s3_request_params_.storage_class); | ||
|
|
||
| std::string value; | ||
| if (!context->getProperty(Region.getName(), value) || value.empty() || REGIONS.find(value) == REGIONS.end()) { |
There was a problem hiding this comment.
Just fancy: in case you use set, you can rely on count instead of comparing the result of find to end.
| if (is_first) { | ||
| is_first = false; | ||
| } else { | ||
| result_list += ", "; |
There was a problem hiding this comment.
This is already implemented in join.
I bit more simple way of doing this:
auto users : minifi::utils::StringUtils::split(comma_separated_list, ",")
for(auto& user: users) {
auto trimmed_user = minifi::utils::StringUtils::trim(user);
if (trimmed_user.find('@') != std::string::npos) {
user = "emailAddress=\"" + trimmed_user + "\"";
} else {
user = "id=" + trimmed_user;
}
}
return minifi::utils::StringUtils::join(", ", users);
arpadboda
approved these changes
Oct 27, 2020
- Uplift requires initializing AWS API earlier (before initializing client config) - Moving S3 wrapper to S3 namespace - Moving implementations to cpp files
lordgamez
force-pushed
the
MINIFICPP-1376
branch
from
e994558
to
7f5c2cb
Compare
fgerlits
pushed a commit
to fgerlits/nifi-minifi-cpp
that referenced
this pull request
Oct 29, 2020
Signed-off-by: Arpad Boda <aboda@apache.org> This closes apache#915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of PutS3Object processor. The purpose of the processor is to upload an S3 object created from a flow file to AWS storage.
Jira issue: https://issues.apache.org/jira/browse/MINIFICPP-1376
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically main)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.