Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINIFICPP-1398 Add strftime-based fallback to EL :format() when the date.h library is not available #930

Closed
wants to merge 6 commits into from

Conversation

szaszm
Copy link
Member

@szaszm szaszm commented Oct 27, 2020

  • Implement fallback expr_format for the UTC/GMT and localtime cases based on strftime/std::put_time
  • Make the current behavior of unsetting EXPRESSION_LANGUAGE_USE_DATE on windows explicit
  • Move existing tests covering cases implemented in the fallback outside of the #ifdef guard
  • Enable :format() and :toDate() regardless of EXPRESSION_LANGUAGE_USE_DATE

Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file?
  • If applicable, have you updated the NOTICE file?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.

@arpadboda arpadboda closed this in d94e14f Oct 28, 2020
fgerlits pushed a commit to fgerlits/nifi-minifi-cpp that referenced this pull request Oct 29, 2020
… date.h library is not available

std::put_time is not available on gcc 4.8, changing to strftime

attempt to fix gcc 4.8 and mac failures, change to posix-only thread-safe zoning functions

Signed-off-by: Arpad Boda <aboda@apache.org>

This closes apache#930
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants