Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

MINIFI-420 Migrate Windows service executable handling to minifi-assembly #107

Merged
merged 1 commit into from
Dec 18, 2017

Conversation

apiri
Copy link
Member

@apiri apiri commented Dec 18, 2017

MINIFI-420 Migrate Windows service executable handling to minifi-assembly to avoid executables in source packages.

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
  • [-] Have you written or updated unit tests to verify your changes?
  • [-] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [-] If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
  • [-] If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

  • [-] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jzonthemtn
Copy link
Contributor

Does that same stuff need removed from nifi-minifi/minifi-nar-bundles/minifi-framework-bundle/minifi-framework/minifi-resources/pom.xml?

@apiri
Copy link
Member Author

apiri commented Dec 18, 2017

@jzonthemtn indeed it should be... not sure why my commit didn't capture that.

@apiri
Copy link
Member Author

apiri commented Dec 18, 2017

@jzonthemtn great catch. I have pushed another commit removing those and build looks good on my side. I have not been doing so hot in this release process 😵

@jzonthemtn
Copy link
Contributor

@apiri Looks good. That's what RCs are for!

@apiri
Copy link
Member Author

apiri commented Dec 18, 2017

@jzonthemtn indeed, and I am making several of them 😅 ! thanks for scoping out. much appreciated!

…mbly to avoid executables in source packages.

This closes apache#107.
@asfgit asfgit merged commit 3e592b4 into apache:master Dec 18, 2017
@apiri apiri deleted the MINIFI-420 branch September 25, 2018 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants