This repository has been archived by the owner on May 14, 2021. It is now read-only.
MINIFI-524 Added ARM64 Docker for MiniFi so that Minifi can be Used on Edge systems like Raspberry PI #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changed one prop for build |
|
closing for some edits |
|
reopening after changes for travis |
apiri
suggested changes
Mar 24, 2020
There was a problem hiding this comment.
Hey @MATRIX4284 sorry for the delay on the review. I think the approach is mostly okay but would prefer to have this consolidated a bit more with the main Docker items as we seem to get a fair bit of duplication as a result.
Comment on lines
50
to
54
| #USER minifi | ||
|
|
||
| #RUN mkdir a | ||
|
|
||
| #RUN ls -lrt |
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| --> | ||
| # Docker Image Quickstart |
There was a problem hiding this comment.
Could we look to augment the base README in lieu of having another copy?
There was a problem hiding this comment.
I have updated the readme base
|
Updated Docker file as well as readme |
|
Please let me know regarding the plan for the merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi - MiNiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.