MINIFI-81 Adding a check for a valid command to the config.sh toolkit… #39
Conversation
|
reviewing |
| @@ -85,8 +85,6 @@ public static void main(String[] args) { | |||
| public static void printValidateUsage() { | |||
| System.out.println("Validate Usage:"); | |||
| System.out.println(); | |||
| System.out.print("java "); | |||
There was a problem hiding this comment.
Should this and the other java invocation remain given that the interpretation of arguments is handled by the script when invoked from the script? This is valid in the context the class is run by itself.
There was a problem hiding this comment.
Hey @apiri, I chose to remove them because they can lead to very confusing errors messages for user who ran it using the scripts. If they happen to mis-type a file location not only would they see the error saying the file doesn't exist but also this "java ..." line that was quite confusing.
Also, I see this being run using the script in >99% of the cases.
|
Everything looks good. Just wondering if we should keep usage for the main class such that it is applicable if run independently of the script. If not, would think we should perhaps just nix those two methods entirely. |
… script