Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

MINIFI-127: Added quick start document. #49

Closed
wants to merge 2 commits into from

Conversation

thesolson
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?
  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@brosander
Copy link
Contributor

@thesolson it looks like there need to be some newlines in this section to make the numbered lists appear properly.

I think I usually do a newline before and after the list.

@apiri
Copy link
Member

apiri commented Nov 11, 2016

hey @thesolson,

got to scope this out and overall looks good. some folks also had some additional commentary for some minor fixes, but otherwise looks like a great start and will certainly be helpful for getting people going down the appropriate path

@JPercivall
Copy link
Contributor

@apiri @thesolson I created a patch addressing the feedback that was left. Just rename it from ".txt" to ".patch" to apply it.

0001-MINIFI-127-In-quick-start-guide-removing-processors-.txt

…ly unusable due to reliance on Controller Services other than SSL Context
@thesolson
Copy link
Contributor Author

@apiri I've applied Joe's patch. The changes look great! Please feel free to finalize the review and merge if appropriate.

@apiri
Copy link
Member

apiri commented Nov 30, 2016

@thesolson & @JPercivall,

Thanks for the updates/patches. Looks good here and will get this merged in.

@asfgit asfgit closed this in bcf6c6c Nov 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
5 participants