MINIFI-15 Created a config file format with documentation, and a Util… #8
Conversation
… class to transform prospective config.yml into flow.xml and nifi.properties
| private ConfigTransformer() {} | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
| transformConfigFile("./config.yml", |
There was a problem hiding this comment.
This looks like a remnant from development
There was a problem hiding this comment.
Yup, that is correct. Removing
| @@ -45,5 +45,16 @@ limitations under the License. | |||
| <groupId>org.apache.nifi</groupId> | |||
| <artifactId>nifi-expression-language</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>org.yaml</groupId> | |||
There was a problem hiding this comment.
Will need to include this in the appropriate LICENSE/NOTICE files.
There was a problem hiding this comment.
Snakeyaml is licensed using an apache 2.0 license and does not include a notice[1]. It is my understanding that you don't need to do anything if both those are true.
There was a problem hiding this comment.
Yep, agreed. Didn't notice there wasn't a... NOTICE. :)
There was a problem hiding this comment.
|
Overall looks good and a great start for helping to start experimenting and see how this all works and what configuration needs to be exposed to the user. Would like the input stream to be handled where noted, but that is the only issue to be addressed I can see. |
|
Addressed the comments in a new commit. |
|
Looks good to go. +1. Will leave to you to squash and merge. Thanks! |
|
Thanks for the review, I merged in the changes |
… class to transform prospective config.yml into flow.xml and nifi.properties