Skip to content
This repository has been archived by the owner on May 14, 2021. It is now read-only.

MINIFI-409: Skipping failing tests on Windows. #97

Closed
wants to merge 1 commit into from
Closed

MINIFI-409: Skipping failing tests on Windows. #97

wants to merge 1 commit into from

Conversation

jzonthemtn
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi - MiNiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi-minifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under minifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under minifi-assembly?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@jzonthemtn jzonthemtn changed the title MINIFI-409: Skipping testMergeJournalsEmptyJournal test on Windows. MINIFI-409: Skipping failing tests on Windows. Nov 2, 2017
@apiri
Copy link
Member

apiri commented Nov 14, 2017

These have been problematic in NiFi as well. Will get this merged. Thanks!

@asfgit asfgit closed this in 7a8f185 Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants