This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
NIFIREG-22 Adding versionCount to VersionedFlow with back-end support… #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbende
force-pushed
the
NIFIREG-22
branch
2 times, most recently
from
6ab2310
to
4f7861b
Compare
bbende
force-pushed
the
NIFIREG-22
branch
4 times, most recently
from
41b2013
to
d6c30a3
Compare
… for populating it
kevdoran
approved these changes
Oct 11, 2017
There was a problem hiding this comment.
+1 @bbende - nice work on this!
I reviewed code and did a full build with contrib-check. I ran the web api, verified creating/reading flow snapshots works, and new versionCount field returns correctly. The simplification of the backend through consolidating similar functionality is a nice improvement. LGTM
|
Thanks @kevdoran , going to merge to master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… for populating it