NIFIREG-380 - Allow NiFi Registry admins to configure whether Jetty w…

[thenatog]

…ill send the Jetty server version in responses.

[alopresto]

Reviewing...

[alopresto]

The behavior looks good to me. I am going to add the new property to the default nifi-registry.properties file with a default value of true and then merge.

Before setting nifi.registry.web.should.send.server.version=false in nifi-registry.properties:

curl http://127.0.0.1:18080/nifi-registry -vvv                                                                                                                      22:15:55
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to 127.0.0.1 (127.0.0.1) port 18080 (#0)
> GET /nifi-registry HTTP/1.1
> Host: 127.0.0.1:18080
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 302 Found
< Date: Wed, 08 Apr 2020 05:15:59 GMT
< Location: http://127.0.0.1:18080/nifi-registry/
< Content-Length: 0
< Server: Jetty(9.4.19.v20190610)
<
* Connection #0 to host 127.0.0.1 left intact
* Closing connection 0

After setting nifi.registry.web.should.send.server.version=false in nifi-registry.properties:

curl http://127.0.0.1:18080/nifi-registry -vvv                                                                                                                  22:17:33
*   Trying 127.0.0.1...
* TCP_NODELAY set
* Connected to 127.0.0.1 (127.0.0.1) port 18080 (#0)
> GET /nifi-registry HTTP/1.1
> Host: 127.0.0.1:18080
> User-Agent: curl/7.64.1
> Accept: */*
>
< HTTP/1.1 302 Found
< Date: Wed, 08 Apr 2020 05:17:36 GMT
< Location: http://127.0.0.1:18080/nifi-registry/
< Content-Length: 0
<
* Connection #0 to host 127.0.0.1 left intact
* Closing connection 0

The 404 page does not reveal the server version either.