Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

NIFIREG-441 - Add test data source factory for Postgres 12 & 13 #316

Merged
merged 2 commits into from Feb 25, 2021

Conversation

pvillard31
Copy link
Contributor

Run tests with:

mvn verify -Dspring.profiles.active=postgres-12
mvn verify -Dspring.profiles.active=postgres-13

@bbende
Copy link
Contributor

bbende commented Feb 25, 2021

Tested this out locally and happened to be on a new laptop where I had never run these IT tests before and got a failure:
{"message":"No such image: quay.io/testcontainers/ryuk:0.2.3"}

I'm guessing maybe I always had this image cached before. Found this discussion which mentioned how testcontainers 1.15.1 would have a fix for something similar:
testcontainers/testcontainers-java#3574

Everything passed for me using that version, so can we update that in the root pom?

Also, any reason to not include postgres 12 and 13 in the test-all-dbs profile?

@pvillard31
Copy link
Contributor Author

I just pushed a commit to update the dependency version for testcontainers. Thanks for the review @bbende !

@bbende
Copy link
Contributor

bbende commented Feb 25, 2021

Thanks, tests passing locally now, will merge

@bbende bbende merged commit d715f2f into apache:main Feb 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants