This repository has been archived by the owner on Jul 22, 2021. It is now read-only.
[NIFIREG-117] update sorting function name and add ellipsis to long t… #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ext in sidenav tables
kevdoran
reviewed
Jan 16, 2018
There was a problem hiding this comment.
I'm not sure if this is intended behavior or a bug, but when in the edit group side panel, if I sort the users in group table do be descending, but then click Add User button, the sort order in the users in group table switches back to ascending, even if I make no change in the Add User dialog.
|
Nice catch @kevdoran this is a def a bug. This bug also exists in when editing a user as well as when editing a bucket. I have created https://issues.apache.org/jira/browse/NIFIREG-124 to address this issue but I think this PR can be merged. |
|
Thanks for looking into it @scottyaslan. Will finalize my review and merge this if all else looks good. |
|
+1, merging to master |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ext in sidenav tables