NIFI-8163: When counting number of components, we traverse into all P…

…rocess Groups, but then call findAllRemoteProcessGroups, which is a recursive call, instead of calling getRemoteProcessGroups(). This results in counting the Process Groups many times. So fixed that.

Signed-off-by: Nathan Gough <thenatog@gmail.com>

This closes #4775.

nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/StandardProcessGroup.java

@@ -443,7 +443,7 @@ public ProcessGroupCounts getCounts() {
                 syncFailure += childCounts.getSyncFailureCount();
             }
 
-            for (final RemoteProcessGroup remoteGroup : findAllRemoteProcessGroups()) {
+            for (final RemoteProcessGroup remoteGroup : getRemoteProcessGroups()) {
                 // Count only input ports that have incoming connections
                 for (final Port port : remoteGroup.getInputPorts()) {
                     if (port.hasIncomingConnection()) {