[NIFI-2812] Fix creating NiFi RPM #1047
Conversation
|
@fidget83 thank you for the contribution, can you please create a JIRA that describes the problem this is trying to fix? and then update this PR to include the JIRA number. Thanks. |
|
@bbende, Jira issue is https://issues.apache.org/jira/browse/NIFI-2812 |
|
@fidget83 would you mind amending the commit message and adding reference to the JIRA you mentioned above? You can do so by running |
|
@trixpan, done |
| @@ -505,11 +510,18 @@ language governing permissions and limitations under the License. --> | |||
| <directory>/opt/nifi/nifi-${project.version}/lib</directory> | |||
| <dependency> | |||
| <excludes> | |||
| <exclude>net.minidev:asm</exclude> | |||
| <exclude>asm:asm</exclude> | |||
There was a problem hiding this comment.
are you sure this is necessary?
| @@ -505,11 +510,18 @@ language governing permissions and limitations under the License. --> | |||
| <directory>/opt/nifi/nifi-${project.version}/lib</directory> | |||
| <dependency> | |||
| <excludes> | |||
| <exclude>net.minidev:asm</exclude> | |||
There was a problem hiding this comment.
are you sure this is necessary?
| <exclude>net.minidev:asm</exclude> | ||
| <exclude>asm:asm</exclude> | ||
| <exclude>org.bouncycastle:bcpkix-jdk15on</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude> |
There was a problem hiding this comment.
seems to be absent from tar file? Sure it is required?
| <exclude>asm:asm</exclude> | ||
| <exclude>org.bouncycastle:bcpkix-jdk15on</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-core</exclude> |
There was a problem hiding this comment.
seems to be absent from tar file? Sure it is required?
| <exclude>org.bouncycastle:bcpkix-jdk15on</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-core</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-databind</exclude> |
There was a problem hiding this comment.
seems to be absent from tar file? Sure it is required?
| <exclude>com.fasterxml.jackson.core:jackson-annotations</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-core</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-databind</exclude> | ||
| <exclude>com.jayway.jsonpath:json-path</exclude> |
There was a problem hiding this comment.
seems to be absent from tar file? Sure it is required?
| <exclude>com.fasterxml.jackson.core:jackson-core</exclude> | ||
| <exclude>com.fasterxml.jackson.core:jackson-databind</exclude> | ||
| <exclude>com.jayway.jsonpath:json-path</exclude> | ||
| <exclude>net.minidev:json-smart</exclude> |
There was a problem hiding this comment.
seems to be absent from tar file? Sure it is required?
| <exclude>org.apache.nifi:nifi-bootstrap</exclude> | ||
| <exclude>org.apache.nifi:nifi-resources</exclude> | ||
| <exclude>org.apache.nifi:nifi-docs</exclude> | ||
| <exclude>commons-io:commons-io</exclude> | ||
| <exclude>org.apache.commons:commons-lang3</exclude> |
There was a problem hiding this comment.
seems to be present in the tar file but no longer added to the rpm?
|
@trixpan, I just unified the list of jars in rpm and in created .tar.gz.file. I didn't analyze necessary of each jar, but with this set nifi works :) |
|
@fidget83 the JARs should not be unified, instead only the appropriate JARs should go into each directory. Would you mind amending your commit? Kind regards |
|
Hi, I've tested this and the output files from rpm package is the same of tar.gz. |
|
Notes:
LGTM, will merge later today. |
I've added script nifi_env.sh to bin directory and fixed jars in /lib and /lib/bootstrap directories.
Now if I installed NiFi from rpm, its run correctly.