NIFI-2963 FetchHDFS should support Compression Codec property #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing. . . |
olegz
reviewed
Nov 2, 2016
|
|
||
| // Check if we should infer compression codec | ||
| if (inferCompressionCodec) { | ||
| codec = compressionCodecFactory.getCodec(path); |
There was a problem hiding this comment.
I am not sure I understand what;s happening here in relation to line:134. Since both IF statements evaluate inferCompressionCodec this will always override the value of 'codec' (the one that was set in line:134) if it's true.
pvillard31
force-pushed
the
fetchhdfs-compression-codec
branch
from
97332aa
to
b638098
Compare
|
duh... I must admit I did copy/paste the logic from the GetHDFS processor and didn't catch the loop over files in the GetHDFS processor. Anyway, this should now make much more sense. Thanks for catching that Oleg! |
|
@pvillard31 much cleaner, thx. merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.