Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3061 PutAzureEventHub blocks after network interruption #1250

Closed
wants to merge 1 commit into from

Conversation

jfrazee
Copy link
Member

@jfrazee jfrazee commented Nov 19, 2016

This change maintains status quo and does not enable the existing unit tests. The change was tested against NIFI-3061.xml though. As mentioned in NIFI-3070, there isn't a good way to provide meaningful unit tests so integration tests should be added as a new improvement.

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?
  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?
  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?

@ijokarumawak
Copy link
Member

Reviewing...

@asfgit asfgit closed this in e731f09 Nov 21, 2016
@ijokarumawak
Copy link
Member

I've confirmed the upgrade works without problem using my Azure environment. +1, merged into master.
I agree with the idea of improving integration test. Thank you, @jfrazee !!

dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
This closes apache#1250.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
This closes apache#1250.

Signed-off-by: Koji Kawamura <ijokarumawak@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants