Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2655 Handle absence of -n/-l flag for encrypt-config.sh #1262

Closed
wants to merge 1 commit into from

Conversation

alopresto
Copy link
Contributor

This PR is already rebased against PR 1261 so it should not be merged to master until after that PR is merged. Once that occurs, this PR will drop to a much smaller changeset.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@alopresto alopresto changed the title [WIP] NIFI-2655 [WIP] NIFI-2655 Handle absence of -n/-l flag for encrypt-config.sh Nov 22, 2016
@alopresto alopresto changed the title [WIP] NIFI-2655 Handle absence of -n/-l flag for encrypt-config.sh NIFI-2655 Handle absence of -n/-l flag for encrypt-config.sh Nov 23, 2016
@alopresto
Copy link
Contributor Author

I rebased this after PR 1261 was merged to master. Ready for review.

Added and updated unit tests.
Cleaned up unnecessary and commented code.
Removed ignored unit tests.
Cleaned up commented code.
@asfgit asfgit closed this in 1b2b9f1 Nov 23, 2016
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
Added and updated unit tests.
Cleaned up unnecessary and commented code.
Removed ignored unit tests.
Cleaned up commented code.

This closes apache#1262.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
dstreev pushed a commit to dstreev/nifi-1 that referenced this pull request Dec 9, 2016
Added and updated unit tests.
Cleaned up unnecessary and commented code.
Removed ignored unit tests.
Cleaned up commented code.

This closes apache#1262.

Signed-off-by: Andy LoPresto <alopresto@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant