Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3214: Added fetch and replace to DistributedMapCache #1410

Closed
wants to merge 1 commit into from

Conversation

ijokarumawak
Copy link
Member

There's no Processor that utilizes these new cache operations yet, but will be added by JIRA-3216. To test client and server communication, please use org.apache.nifi.distributed.cache.server.TestServerAndClient test class in nifi-distributed-cache-server project. If you need to test it on Mac OS X, then you also have to comment out these lines. Sometime it fails due to JVM issue but sometime it works:

Assume.assumeFalse("test is skipped due to build environment being OS X with JDK 1.8. See https://issues.apache.org/jira/browse/NIFI-437",
    SystemUtils.IS_OS_MAC && SystemUtils.IS_JAVA_1_8);
  • Using fetch and replace together can provide optimistic locking for concurrency control.
  • Added fetch to get cache entry with its meta data such as revision number.
  • Added replace to update cache only if it has not been updated.
  • Added Map Cache protocol version 2 for those new operations.
  • Existing operations such as get or put can work with protocol version 1.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

- Using fetch and replace together can provide optimistic locking for
  concurrency control.
- Added fetch to get cache entry with its meta data such as revision
  number.
- Added replace to update cache only if it has not been updated.
- Added Map Cache protocol version 2 for those new operations.
- Existing operations such as get or put can work with protocol version
  1.
@bbende
Copy link
Contributor

bbende commented Jan 16, 2017

Reviewing...

@bbende
Copy link
Contributor

bbende commented Jan 16, 2017

+1 Verified build passes with contrib-check, tested the Wait/Notify processors to test original cache functionality, code looks good, will merge to master, thanks Koji!

@asfgit asfgit closed this in ef54a8e Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants