Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3420 Add Hadoop-readable Lz4 compression #1457

Closed
wants to merge 5 commits into from

Conversation

ilganeli
Copy link

@ilganeli ilganeli commented Jan 30, 2017

  • This is an initial contribution of a fix for NIFI-3420
  • This code is not yet tested
  • Unit tests will be added soon.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@ilganeli
Copy link
Author

I've added unit tests but am closing this issue for now. There is a substantial blocker to this approach since it leverages the classes from Hadoop which themselves depend on natively compiled and loaded C code. Unless NiFi explicitly adds the C-code for the Lz4 codec and manually builds and loads that library, we won't be able to use the Codec in Hadoop.

I've also evaluated using the lz4-java library instead but this does not generate data in a Hadoop readable format.

@ilganeli ilganeli closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant