NIFI-3454 Tests should consistently use the FileNameFilter when reading file names from directories

[ottobackwards]

Tests that work with getting files from directories ( either doing listings or building URLs for the classloader ) should use the FileNameFilter to ensure unwanted files don't fowl the tests.

As an example, on Mac OS .DS_Store files will break some tests if present

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

• [ x] Is there a JIRA ticket associated with this PR? Is it referenced
  in the commit message?

• [ x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

• [x ] Has your PR been rebased against the latest commit within the target branch (typically master)?

• [x ] Is your initial contribution a single, squashed commit?

For code changes:

• [ x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
• Have you written or updated unit tests to verify your changes?
• If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
• If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
• If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
• If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

• Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

[ijokarumawak]

@ottobackwards Reviewed the changes. Confirmed that both test runs successfully even if there's a .DS_Store file in the test input directory. +1

Please note that when you submit a PR for a JIRA, push the "submit patch" button to move JIRA status forward to "Patch Available". This ensure other developers to know it's ready for PR.

https://cwiki.apache.org/confluence/display/NIFI/Contributor+Guide#ContributorGuide-CodeReviewProcess

I'm going to merge this. Thank you for you contributing!

[ijokarumawak]

@ottobackwards Sorry, I forgot to add "This closes #xxxx. " in the commit message. Would you please close this PR? It's already merged in the master branch. Thanks!

[ottobackwards]

Sorry, will do next time. Your Jira is different from my other apache project

…

On February 10, 2017 at 19:10:28, Koji Kawamura ***@***.***) wrote: @ottobackwards <https://github.com/ottobackwards> Sorry, I forgot to add "This closes #xxxx. " in the commit message. Would you please close this PR? It's already merged in the master branch. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1497 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABD1_wgtI6tQQ5Y4XZ5h5UyTS9k_2C3Yks5rbPx0gaJpZM4L9fY2> .

[ottobackwards]

Will do later tonight

…

On February 10, 2017 at 19:10:28, Koji Kawamura ***@***.***) wrote: @ottobackwards <https://github.com/ottobackwards> Sorry, I forgot to add "This closes #xxxx. " in the commit message. Would you please close this PR? It's already merged in the master branch. Thanks! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1497 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABD1_wgtI6tQQ5Y4XZ5h5UyTS9k_2C3Yks5rbPx0gaJpZM4L9fY2> .