NIFI-2829 Date and Time Format Support for PutSQL #1524
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patricker
changed the title
mattyb149
reviewed
Mar 2, 2017
| final ResultSet rs = stmt.executeQuery("SELECT * FROM TIMESTAMPTEST3 ORDER BY ID"); | ||
| assertTrue(rs.next()); | ||
| assertEquals(1, rs.getInt(1)); | ||
| assertEquals(68522000L, rs.getTime(2).getTime()); |
There was a problem hiding this comment.
This assert is failing for me, presumably because the format was ISO_LOCAL_TIME and I am at -0500 UTC. Perhaps change the constant to something that takes timezone into account?
mattyb149
reviewed
Mar 2, 2017
| assertTrue(rs.next()); | ||
| assertEquals(1, rs.getInt(1)); | ||
| assertEquals(68522000L, rs.getTime(2).getTime()); | ||
| assertEquals(1012633200000L, rs.getDate(3).getTime()); |
There was a problem hiding this comment.
Same goes for this guy. Are the second and third flow files supposed to put in UTC-based dates/times? Or will they be local as well? If the latter then the same change of constants will be needed for the asserts below.
11 tasks
|
I reviewed and confirmed #1983 addressed the unit test timezone issue. So, merged this #1524 and #1983 to master. Thanks @patricker and @yjhyjhyjh0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@paulgibeault made the original PR for this, #1073.
We lost a bit of traction, had some technical issues, and it just didn't get merged.
Then #1468 came along and covered a portion of the work with a great approach. (thanks @nickcarenza)
I've gone back and updated the original code to work with the new paradigm introduced by #1468 so that it also supports
DATEandTIMEcolumn types, and not justTIMESTAMPones.For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.