Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-3545: Release M FlowFilews once N signals arrive #1554

Closed
wants to merge 1 commit into from

Conversation

ijokarumawak
Copy link
Member

  • Support multiplle incoming FlowFiles to Wait processor, up to Wait
    Buffer Count
  • Added Releasable FlowFile Count, which controls how many FlowFiles can
    be released when wait condition is met
  • Added special meaning to Notify delta Zero(0) to clear a signal
    counter back to zero

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

- Support multiplle incoming FlowFiles to Wait processor, up to Wait
  Buffer Count
- Added Releasable FlowFile Count, which controls how many FlowFiles can
  be released when wait condition is met
- Added special meaning to Notify delta Zero(0) to clear a signal
  counter back to zero
@ijokarumawak
Copy link
Member Author

Dear reviewer,

I've tested this PR with different use-cases. Templates and screenshots are available at this Gist.

Thanks in advance!

@apiri
Copy link
Member

apiri commented Mar 2, 2017

reviewing

@apiri
Copy link
Member

apiri commented Mar 6, 2017

Was able to test this in a variety of situations and using your supplied templates. Works as anticipated and thanks for all the tests. Will get this merged in! Thanks!

@asfgit asfgit closed this in 000414e Mar 6, 2017
aperepel pushed a commit to aperepel/nifi that referenced this pull request Mar 29, 2017
- Support multiplle incoming FlowFiles to Wait processor, up to Wait
  Buffer Count
- Added Releasable FlowFile Count, which controls how many FlowFiles can
  be released when wait condition is met
- Added special meaning to Notify delta Zero(0) to clear a signal
  counter back to zero

  This closes apache#1554

Signed-off-by: Aldrin Piri <aldrin@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants