Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2907 Fix Flow Schema Validation Errors #1587

Closed
wants to merge 1 commit into from
Closed

NIFI-2907 Fix Flow Schema Validation Errors #1587

wants to merge 1 commit into from

Conversation

jvwing
Copy link
Contributor

@jvwing jvwing commented Mar 12, 2017

This PR contains two changes to flow.xml schema validation:

1.) Schema validation errors are now handled and logged to the nifi-app.log file as warnings, with text indicating that these are schema validation errors for the flow configuration. This should eliminate ominously vague nastygrams in the bootstrap log file. The new warnings look like this:

2017-03-11 12:36:13,329 WARN [main] o.a.n.c.StandardFlowSynchronizer Schema validation error parsing Flow Configuration at line 52, col 40: cvc-complex-type.2.4.a: Invalid content was found starting with element 'template'. One of '{processor, inputPort, outputPort, label, funnel, processGroup, remoteProcessGroup, connection, controllerService}' is expected.

2.) The FlowConfiguration.xsd schema has been updated to include templates. I did not detail the schema of the snippet element that forms most of a template, for the following reasons:

  • I'm lazy
  • While the snippet contents are logically similar to the RootProcessGroupType or ProcessGroupType, snippets are serialized through a different process which produces different element names and element ordering. I do not believe it is possible to reuse the schema types for processors, process groups, connectors, etc. A new parallel set of snippet-specific schema types would be needed, and I'm not convinced that would add value to the validation.
  • Combining the two factors above, I decided that addressing the validation errors for templates was enough.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@asfgit asfgit closed this in f9b5bcf Mar 28, 2017
@markap14
Copy link
Contributor

@jvwing OK, got this reviewed. As far as I can tell it all follows exactly what we write out now. Many thanks for getting this addressed. Sorry it took so long to review! Got it merged to master now though. Thanks again!

@jvwing
Copy link
Contributor Author

jvwing commented Mar 28, 2017

Thanks, @markap14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants