Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2323: Fixed Oracle timestamp handling in DB fetch processors #1664

Closed
wants to merge 1 commit into from

Conversation

mattyb149
Copy link
Contributor

@mattyb149 mattyb149 commented Apr 11, 2017

I tested this on Oracle 11g XE with tables containing TIMESTAMP and DATE fields. The state is now stored as timestamps (dates have a time-of-day of zero/midnight)


Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@@ -413,7 +400,7 @@ protected static String getLiteralByType(int type, String value, String database
case TIMESTAMP:
// Timestamp literals in Oracle need to be cast with TO_DATE
if ("Oracle".equals(databaseType)) {
return "to_date('" + value + "', 'yyyy-mm-dd HH24:MI:SS')";
return "timestamp '" + value + "'";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably breaks backwards compatibility if the processor has already stored a Date (no time-of-day) into the StateMap. To preserve backwards compatibility, we should check if the value is just a Date and use the "date" coercion instead of the "timestamp" coercion. If that succeeds, then the next maximum value observed should be stored as a full timestamp and the "date" coercion should no longer be executed

@markap14
Copy link
Contributor

This looks good to me. Code is clean and makes sense. Contrib-check passes with all unit tests. +1 merged to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants