Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4064 Make sure that Funnels with queued incoming FlowFiles, but no outgoing connections yield rather than continually check to run. #1914

Closed
wants to merge 1 commit into from

Conversation

Wesley-Lawrence
Copy link
Contributor

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • [✓] Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • [✓] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • [✓] Has your PR been rebased against the latest commit within the target branch (typically master)?

  • [✓] Is your initial contribution a single, squashed commit?

For code changes:

  • [✓] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • [✓] Have you written or updated unit tests to verify your changes?
  • [N/A] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • [N/A] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • [N/A] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • [N/A] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • [N/A] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@Wesley-Lawrence Wesley-Lawrence force-pushed the NIFI-4064 branch 4 times, most recently from dcf73da to 27f05ba Compare June 13, 2017 15:59
…no outgoing connections yield rather than continually check to run.
@Wesley-Lawrence
Copy link
Contributor Author

Fixed and re-squashed the license issue travis found. I suspect the appveyor issues isn't an issue? mvn -Pcontrib-check clean install worked fine locally (after a couple of restarts).

@asfgit asfgit closed this in 5a7e6c6 Jun 17, 2017
@pvillard31
Copy link
Contributor

+1, checked the behavior with and without the fix, LGTM, merged to master, thanks @Wesley-Lawrence

mattyb149 pushed a commit to mattyb149/nifi that referenced this pull request Nov 30, 2017
…no outgoing connections yield rather than continually check to run.

Signed-off-by: Pierre Villard <pierre.villard.fr@gmail.com>

This closes apache#1914.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants