Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-2692: Fix for TestListenSMTP tests fail #1924

Closed
wants to merge 1 commit into from

Conversation

cherrera2001
Copy link

@cherrera2001 cherrera2001 commented Jun 16, 2017

  • Removing problematic timeout for SMTP Listen
  • Converting anonymous method to lambda
  • Adding debug and error logging

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message? NIFI-2692

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

- Removing problematic timeout for SMTP Listen
- Converting anonymous method to lambda
- Adding debug and error logging
@asfgit asfgit closed this in 2800df3 Jun 17, 2017
@pvillard31
Copy link
Contributor

+1, merged to master, thanks @cherrera2001

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants