Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4135 - added hadoop-client and enhanced Authorizers entity to su… #1956

Closed
wants to merge 2 commits into from

Conversation

YolandaMDavis
Copy link
Contributor

…pport classpath for resources entry

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@YolandaMDavis
Copy link
Contributor Author

@bbende would appreciate if you could review. Thanks in advance!

@bbende
Copy link
Contributor

bbende commented Jun 28, 2017

Sure, I'll take a look as soon as I wrap up a couple of things.

@bbende
Copy link
Contributor

bbende commented Jun 30, 2017

This looks good! Made sure existing config can run without the new classpath element, and then verified I could start the Ranger authorizer with it.

My only comment, and I know this is super picky, but can we switch the order of class and classpath in the XSD so that it would be identifier, class, classpath?

I think it just reads a little cleaner to know which authorizer we are talking about before reading the classpath.

@YolandaMDavis
Copy link
Contributor Author

@bbende sorry for the delay (was away on vacation). Not a picky request at all; the weirdness I ran into was that the xsd could not resolve the property value if classpath was just before it. It is weird but I think it has something to do with property being unlimited and classpath being not required. I'll give it a try to see if I can resolve or at least recreate it.

@YolandaMDavis
Copy link
Contributor Author

@bbende did add the change to order (couldn't recreate the issue).

@bbende
Copy link
Contributor

bbende commented Jul 7, 2017

+1 looks good, thanks for making the update, I'll merge to master.

@asfgit asfgit closed this in 6df97bb Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants