NIFI-3193: added ability to authenticate with AMQP using cert common names #1971
Conversation
m-hogue
changed the title
| @@ -16,14 +16,14 @@ | |||
| */ | |||
| package org.apache.nifi.amqp.processors; | |||
|
|
|||
| import java.io.IOException; | |||
|
|
|||
| import org.apache.nifi.logging.ComponentLog; | |||
There was a problem hiding this comment.
Hey @m-hogue, thanks for this PR. Can you take care of the not needed changes that have been (most likely) introduced by your IDE? For example this class is marked as changed but there is no actual change in it. It's similar for some files modified by your PR. Thanks!
There was a problem hiding this comment.
Yeah, I'll make sure to avoid this in the future as well
| @@ -97,6 +98,14 @@ | |||
| .required(false) | |||
| .identifiesControllerService(SSLContextService.class) | |||
| .build(); | |||
| public static final PropertyDescriptor USE_CERT_AUTHENTICATION = new PropertyDescriptor.Builder() | |||
| .name("Cert Authentication") | |||
There was a problem hiding this comment.
Could you use .displayName() for what is displayed on the UI? and .name for a more "computer-friendly" name? It's not mandatory but that's a convention we are trying to progressively adopt.
NIFI-3193: final tweaks to formatter
|
@pvillard31 : Thanks for the review! After wrestling with IntelliJ formatting rules following the import of the nifi style config i think it's good. Please let me know if you'd like any more changes made. |
| @@ -63,6 +63,9 @@ | |||
| <li><b>Password</b> - [REQUIRED] password to use with user name to connect to AMQP broker. | |||
| Usually provided by the administrator. Defaults to 'guest'. | |||
| </li> | |||
| <li><b>Cert Authentication</b> - [OPTIONAL] whether or not to use the SSL certificate for authentication rather than user name and password. | |||
There was a problem hiding this comment.
Would it be possible to have this match the displayName text?
|
@m-hogue if you can fix that description in the html, I can merge in. |
… additional details to have similar wording
|
Fixed in 02956f8. Should be gtg. Let me know if there are any other changes needed. |
|
looks good, I'll work on merging it in |
This change allows for PublishAMQP and ConsumeAMQP to use SSL cert authentication instead of username/password. The change is backward compatible, so it shouldn't affect anyone who plans to continue using SSL as a transport and username/password authentication.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.