NIFI-4197 - Expose some proxy settings to GCS Processors #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvwing
reviewed
Sep 10, 2017
| public static final PropertyDescriptor PROXY_PORT = new PropertyDescriptor | ||
| .Builder().name("proxy-port") | ||
| .displayName("Proxy port") | ||
| .description("Porxy port number") |
There was a problem hiding this comment.
"Porxy port number" - looks like a typo
| @@ -55,6 +55,25 @@ | |||
| .addValidator(StandardValidators.INTEGER_VALIDATOR) | |||
| .build(); | |||
|
|
|||
| public static final PropertyDescriptor PROXY_HOST = new PropertyDescriptor | |||
| .Builder().name("proxy-host") | |||
There was a problem hiding this comment.
The other property descriptors in this file prefix their names with gcp-. Any special reason not to fit in with the others?
| .build(); | ||
|
|
||
| public static final PropertyDescriptor PROXY_PORT = new PropertyDescriptor | ||
| .Builder().name("proxy-port") |
There was a problem hiding this comment.
Same thing with the gcp- prefix.
|
@trixpan - Thanks for contributing the proxy feature. It looks pretty good, and worked just fine in my testing with GCS processors. Please take a look at the nit-picks above, but I don't have any more substantial comments at the moment. |
|
@jvwing Apologies for the delay.... I believe the feedback has been addressed. |
|
Thanks, @trixpan. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.