NIFI-4733: Addressing two phase commit logic issue in variable registry #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing... |
alopresto
reviewed
Jan 4, 2018
| @@ -552,41 +553,43 @@ public Response deleteVariableRegistryUpdateRequest( | |||
| public Response updateVariableRegistry( | |||
| @Context final HttpServletRequest httpServletRequest, | |||
| @ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId, | |||
| @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) { | |||
| @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) { | |||
There was a problem hiding this comment.
Should the ApiParam value be updated to reflect that this is VR-specific as opposed to generic PG configuration?
alopresto
reviewed
Jan 4, 2018
| @@ -620,13 +623,13 @@ public Response updateVariableRegistry( | |||
| public Response submitUpdateVariableRegistryRequest( | |||
| @Context final HttpServletRequest httpServletRequest, | |||
| @ApiParam(value = "The process group id.", required = true) @PathParam("id") final String groupId, | |||
| @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestEntity) { | |||
| @ApiParam(value = "The process group configuration details.", required = true) final VariableRegistryEntity requestVariableRegistryEntity) { | |||
|
I ran a cluster with the patch applied and ensured no regressions on the two phase commit. Once the minor fixes are done, I can merge, but I'll leave the pre-emptive +1 here in case I am away from my computer. Ran |
- Resolving logic issue in two phase commit when updating variable registry. This closes apache#2370
|
Thanks @alopresto! I've addressed the comments here and I will merge to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-4733: