New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-4747 - Removed directory existence check in GetHDFS #2391
Conversation
@@ -220,16 +220,6 @@ | |||
.explanation(MIN_AGE.getName() + " cannot be greater than " + MAX_AGE.getName()).build()); | |||
} | |||
|
|||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should remove this, see this JIRA: https://issues.apache.org/jira/browse/NIFI-2553
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you're absolutely right, thanks! reverted this and added a unit test for the expected use case.
@@ -224,17 +224,6 @@ public void testDirectoryUsesValidEL() throws IOException { | |||
assertTrue(receiveEvent.getTransitUri().endsWith("13545423550275052.zip")); | |||
} | |||
|
|||
@Test | |||
public void testDirectoryUsesUnrecognizedEL() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as previous comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 looks good to me. Pulled down, validated build, and tested against local Hadoop environment to validate that directory which does not exist no longer throws an exception in OnScheduled when trigger view a cron job on a directory that does not exist.
This closes apache#2391 Signed-off-by: Jeremy Dyer <jeremydyer@apache.org>
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.