Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-4756: Updated PublishKafkaRecord processors to include attribute… #2396

Closed
wants to merge 1 commit into from

Conversation

markap14
Copy link
Contributor

…s generated from schema write strategy into the message headers when appropriate

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

…s generated from schema write strategy into the message headers when appropriate
@bbende
Copy link
Contributor

bbende commented Jan 16, 2018

Reviewing...

@bbende
Copy link
Contributor

bbende commented Jan 16, 2018

+1 looks good, verified 0.11 and 1.0 processors send attributes in headers correctly, there was a minor check-style error that i am fixing while merging

@asfgit asfgit closed this in 7c1ce17 Jan 16, 2018
apiri pushed a commit to apiri/incubator-nifi that referenced this pull request May 10, 2018
…s generated from schema write strategy into the message headers when appropriate

This closes apache#2396.

Signed-off-by: Bryan Bende <bbende@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants