New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-4759 Fixed a bug that left a hard-coded reference to _id in as t… #2401
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the PR. I left 3 minor comments. Otherwise it LGTM.
|
||
for (String upsert : upserts) { | ||
runner.setProperty(PutMongo.UPDATE_QUERY_KEY, updateKeyProps[index]); | ||
for (int x = 0; x < 5; x++) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using 2 instead of 5?
@Test | ||
public void testNiFi_4759_Regressions() { | ||
String[] upserts = new String[]{ | ||
"{\n" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about writing the JSON document on one line?
} | ||
} | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd remove this and the empty line above...
…he update key for MongoDB upserts.
6b269dc
to
fb9db99
Compare
@mgaido91 I think it's all done now. |
LGTM, thanks. |
@joewitt @pvillard31 maybe you can help reviewing this too, thanks. |
+1, LGTM, thanks for the PR @MikeThomsen and thanks for the review @mgaido91 |
…he update key for MongoDB upserts.
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
Has your PR been rebased against the latest commit within the target branch (typically master)?
Is your initial contribution a single, squashed commit?
For code changes:
For documentation related changes:
Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.