Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5339 - Better Time Tracking for ExecuteSQL Durations #2817

Closed
wants to merge 1 commit into from

Conversation

patricker
Copy link
Contributor

@patricker patricker commented Jun 26, 2018

ExecuteSQL uses an attribute, executesql.query.duration, to track how long query execution and fetch took.

For multiple result set queries this is a cumulative/running total, and is not specific to each query.

Also, there is no separation between query execution and fetch times.

Updates:

Add a dedicated property executesql.query.executiontime to track the base query execution time.
Add a dedicated property executesql.query.fetchtime to track the per resultset fetch time.
Update the existing executesql.query.duration to be the sum of the other two times.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@pvillard31
Copy link
Contributor

+1, code LGTM, merging to master, thanks @patricker

@asfgit asfgit closed this in c1083df Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants