Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIFI-5329 Made a client service an optional source of connection pool… #2893

Closed
wants to merge 2 commits into from

Conversation

MikeThomsen
Copy link
Contributor

…ing in Mongo processors.

Thank you for submitting a contribution to Apache NiFi.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically master)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
  • If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.

@MikeThomsen
Copy link
Contributor Author

Mongo_client_test.xml.txt

That is a flow for testing the functionality against a Mongo server running on localhost:27017.

@patricker
Copy link
Contributor

patricker commented Jul 16, 2018

@MikeThomsen, you typo'd the JIRA ticket number associated with this PR. (NIFI-5329 vs NIFI-5239); I keep editing my own comment... looks like you used both JIRA numbers in your commit comments, one as 5329, one as 5239. Since NIFI-5329 is about removing files from queues... :)

@MikeThomsen
Copy link
Contributor Author

Thanks. Ill redo this then..

@MikeThomsen MikeThomsen deleted the NIFI-5239 branch July 16, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants